Added and unified options for the gulp test command #2989
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2989 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 208 208
Lines 7758 7758
Branches 1722 1722
=======================================
Hits 7590 7590
Misses 168 168 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hi @esanzgar - I added a couple of thoughts about supplying multiple patterns to grep and a possible alternative to the --browser option which will enable running tests in other browsers without installing additional packages. The --watch change I'm fine with.
gulpfile.js
Outdated
| @@ -34,13 +34,22 @@ const IMAGES_DIR = 'build/images'; | |||
| function parseCommandLine() { | |||
| commander | |||
| .option( | |||
| '--grep [pattern]', | |||
| '--grep [pattern...]', | |||
| 'Run only tests where filename matches a pattern' | |||
There was a problem hiding this comment.
Since pattern is a regex, the way I run tests that match one of several patterns is just --grep A|B where "A" and "B" are patterns to match. What might be helpful here though is to change "a pattern" to "a regex pattern" to clarify that it isn't a minimatch pattern or something like that.
There was a problem hiding this comment.
Related to this, one annoying issue at the moment is that this help documentation only exists in the code. If you run gulp test --help you get Gulp's help output, not the output for the specific command. It would be nice to fix that somehow.
There was a problem hiding this comment.
I have changed the help text as you suggested.
I will remove the options to allow multiple --grep options.
Regarding adding our own help documentation:
- it is been discussed in the gulp project: gulp treats flags after -- as task names gulpjs/gulp#2383
- another alternative: https://www.npmjs.com/package/gulp-display-help
gulpfile.js
Outdated
| .option( | ||
| '--browser [browsers...]', | ||
| 'Run test with this browsers (default "ChromeHeadless_Custom")', | ||
| ['ChromeHeadless_Custom'] |
There was a problem hiding this comment.
Unfortunately with this option you can only specify ChromeHeadless or Chrome since those are the only launchers installed. What I was going to suggest doing instead is to have an option that doesn't launch any browser automatically but instead just launches Karma and waits for the user to load the Karma server in a browser of their choice. When calling the Karma API, this just requires setting the browsers argument to null.
I'm sure what the best name for such an option would be - --no-launch-chrome ("Don't launch headless Chrome to run the tests. Navigate to http://localhost:9876/ to run the tests.")?
There was a problem hiding this comment.
I think it is a very good idea to allow developers to run the test in whatever browser they wish. I added the option --no-browser for that.
esanzgar
force-pushed
the
karma-options
branch
from
becd251
to
679ab62
Compare
|
@robertknight, thank you for reviewing my PR and your comments.
|
esanzgar
force-pushed
the
karma-options
branch
3 times, most recently
from
7455f55
to
aa7021b
Compare
The purpose of this PR is to be able to easily run karma tests in other browsers without manually editing the karma configuration or making local copies of the karma configuration. Additions: - `yarn test --no-browser` to avoid launching the default browser. It is up to the developer to run the tests in whatever browser she/he chooses by navigating to http://localhost:9876/. - `yarn test --browser <browser>` run the tests in a different browser/s instead of the default browser. Chrome launcher comes by default with karma. Firefox, Safari and others can be installed independently. Modifications: - `yarn gulp test-watch` has been substituted by `yarn test --watch` for consistency.
With the recent changes in the gulp test command (#2989), everything that could be achieved by `make servetest` can be done by options to the `make test` target.
With the recent changes in the gulp test command (#2989), everything that could be achieved by `make servetest` can be done by options to the `make test` target.
The purpose of this PR is to be able to easily run karma tests in other
browsers without manually editing or making local copies of the karma
configuration.
Additions:
yarn gulp test --no-browserto avoid launching the default browser.It is up to the developer to run the tests in whatever browser she/he
chooses by navigating to http://localhost:9876/.
yarn gulp test --browser <browser>run the tests in a differentbrowser/s instead of the default browser. Chrome launcher comes by
default with karma. Firefox, Safari and others can be installed
independently.
Modifications:
yarn gulp test-watchhas been substituted byyarn gulp test --watchfor consistency.