feat: add a new ValueOrUndefined common type #2551
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2551 +/- ##
==========================================
- Coverage 82.99% 82.20% -0.79%
==========================================
Files 925 927 +2
Lines 20628 20860 +232
Branches 3253 3310 +57
==========================================
+ Hits 17120 17149 +29
- Misses 3388 3574 +186
- Partials 120 137 +17 ☔ View full report in Codecov by Sentry. |
itssharmasandeep
approved these changes
Nov 29, 2023
| @@ -35,3 +35,4 @@ export interface Json { | |||
| export type JsonValue = Json | Json[] | string | number | boolean | null; | |||
| export type PrimitiveValue = string | number | boolean; | |||
| export type ValueOrNull<T> = T | null; | |||
| export type ValueOrUndefined<T> = T | undefined; | |||
There was a problem hiding this comment.
How's this differ from ?: T?
There was a problem hiding this comment.
its the same. I feel this is just a bit more cleaner when we have to return something from a function or use this as a type instead of doing | undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new generic type.