Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation mask issue with quantification of single spectrum #2603

Merged
merged 2 commits into from Dec 21, 2020

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Dec 21, 2020

One test added in #2602 failed on RELEASE_next_minor because when doing the quantification of a single spectrum, a navigation mask is computed automatically and clearly it shouldn't!

Progress of the PR

  • Fix setting navigation_mask for the quantification of single spectrum
  • add tests,
  • ready for review.

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #2603 (eeaabec) into RELEASE_next_minor (ec16cda) will increase coverage by 2.42%.
The diff coverage is 87.13%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           RELEASE_next_minor    #2603      +/-   ##
======================================================
+ Coverage               74.04%   76.47%   +2.42%     
======================================================
  Files                     197      202       +5     
  Lines                   27867    29748    +1881     
  Branches                 6037     6498     +461     
======================================================
+ Hits                    20635    22749    +2114     
+ Misses                   5521     5202     -319     
- Partials                 1711     1797      +86     
Impacted Files Coverage Δ
hyperspy/_components/eels_arctan.py 89.47% <ø> (-1.01%) ⬇️
hyperspy/_components/voigt.py 88.88% <ø> (-0.21%) ⬇️
hyperspy/_signals/complex_signal2d.py 100.00% <ø> (ø)
hyperspy/api.py 100.00% <ø> (+50.00%) ⬆️
hyperspy/decorators.py 85.71% <ø> (+7.77%) ⬆️
hyperspy/drawing/_widgets/label.py 64.91% <ø> (ø)
hyperspy/drawing/tiles.py 0.00% <ø> (ø)
hyperspy/io_plugins/empad.py 93.54% <ø> (ø)
hyperspy/io_plugins/msa.py 75.60% <ø> (-0.30%) ⬇️
hyperspy/model.py 80.33% <ø> (+8.08%) ⬆️
... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a1772a...eeaabec. Read the comment docs.

@ericpre
Copy link
Member Author

ericpre commented Dec 21, 2020

Doc build fails because of latest sphinx release: sphinx-doc/sphinx#8568

@ericpre ericpre merged commit ab246dd into hyperspy:RELEASE_next_minor Dec 21, 2020
@ericpre ericpre deleted the fix_vacuum_mask branch December 22, 2020 18:07
@ericpre ericpre added this to the v1.7 milestone Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant