New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #2348
Fix CI #2348
Conversation
…encies since it is not available on pip and it breaks the pip installation. The motivation was to avoid installing qt with conda but it only saves a few seconds of CI and it is not worth it.
The travis results does not show in the "check list" at the moment. According to this issue (https://travis-ci.community/t/travis-ci-build-no-longer-showing-as-check-on-github-pull-request-page/6955/5), it may be necessary to reset grant access to Travis CI to fix it. I have just did for my account and it worked. |
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_patch #2348 +/- ##
===================================================
Coverage 71.65% 71.66%
===================================================
Files 177 177
Lines 20947 20947
Branches 4444 4444
===================================================
+ Hits 15010 15011 +1
+ Misses 4627 4626 -1
Partials 1310 1310
Continue to review full report at Codecov.
|
.travis.yml
Outdated
@@ -51,6 +51,9 @@ install: | |||
- if [[ $MINIMAL_ENV == false ]] ; then | |||
DEPS="${DEPS} ${DEPS_OPTIONAL}"; | |||
fi | |||
- if [[ $ENV == pip ]] ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some comments here explaining why this is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was to check that the pillow version was the issue. pillow 7.1.1 have been released a few hours ago, once it is available on pypi, I will remove this.
The png issue should be fixed in pillow 7.1.1 (python-pillow/Pillow#4512, python-pillow/Pillow#4515)