Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate package metadata in pyproject.toml #5

Closed
wants to merge 1 commit into from

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Aug 26, 2023

No description provided.

*********

Changelog entries for the development version are available at
https://rosettasciio.readthedocs.io/en/latest/changes.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://rosettasciio.readthedocs.io/en/latest/changes.html
https://holospy.readthedocs.io/en/latest/changes.html

@ericpre ericpre marked this pull request as draft August 28, 2023 09:59
@ericpre
Copy link
Member Author

ericpre commented Aug 28, 2023

I am converting to draft, because it currently doesn't work in "editable" installation (pip install -e .) because the files of the package doesn't appear in the dist.files:

from importlib import metadata

_external_extensions = tuple(metadata.entry_points(group="hyperspy.extensions"))
holospy_ext = _external_extensions[0]
print(holospy_ext.dist.files)

@ericpre
Copy link
Member Author

ericpre commented Aug 29, 2023

It seems that currently it can't not work with editable install because the loading extension mechanism use importlib.metadata to find the relevant yanl file and in case of editable the module are in included in dist.files provided by importlib.metadata.
See python/cpython#96144, python/importlib_metadata#402 and pypa/packaging-problems#620 for more information.

Closing for now, we can revisit, when they will be a solution.

@ericpre ericpre closed this Aug 29, 2023
@ericpre ericpre added this to the v0.1 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants