Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agent): define the OAS for CredentialIssuerEndpoints [WIP] #909

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

feat(agent): define the OAS for CredentialIssuerEndpoints [WIP] #909

wants to merge 30 commits into from

Conversation

yshyn-iohk
Copy link
Member

Description:

The Credential Issuance OIDC endpoint MVP is implemented in the Agent. ATL-6518

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@yshyn-iohk yshyn-iohk marked this pull request as draft February 28, 2024 15:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited

Integration Test Results

15 files  ±0  15 suites  ±0   2s ⏱️ ±0s
33 tests ±0  33 ✅ ±0  0 💤 ±0  0 ❌ ±0 
42 runs  ±0  42 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0eff8cb. ± Comparison against base commit 4ac7a2e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited

Unit Test Results

 94 files  + 3   94 suites  +3   22m 59s ⏱️ + 2m 50s
803 tests +32  795 ✅ +32  8 💤 ±0  0 ❌ ±0 
810 runs  +32  802 ✅ +32  8 💤 ±0  0 ❌ ±0 

Results for commit 0eff8cb. ± Comparison against base commit 4ac7a2e.

♻️ This comment has been updated with latest results.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

yshyn-iohk and others added 17 commits April 30, 2024 12:27
@yshyn-iohk @patlo-iog
feat(agent): define the OAS for CredentialIssuerEndpoints
c35103b 
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@yshyn-iohk @patlo-iog
feat(agent): implement Nonce stub endpoint for OIDC credential issuer
c983d4c 
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@yshyn-iohk @patlo-iog
feat(agent): add CredentialIssuerService mock and get walletId by pri…
276865f 
…sm DID method

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@yshyn-iohk @patlo-iog
feat(agent): implement the VC issuance flow with the dummy data
347fe55 
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@yshyn-iohk @patlo-iog
feat(agent): implement the VC issuance flow with the dummy data
d387df2 
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@patlo-iog
feat: credential offer endpoint and keycloak plugin wip (#935)
a7919fe 
Signed-off-by: Pat Losoponkul <pat.losoponkul@iohk.io>
@yshyn-iohk @patlo-iog
feat(agent): add IssuanceSession and NonceService
e648e25 
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@patlo-iog
docs: add example instruction how to run
104731b
@patlo-iog
fix: integrate oidc4vc CredentialOffer to IssuanceSession (#943)
a6c4a25
@yshyn-iohk @patlo-iog
doc(agent): add the details to the readme.md and change the port of t…
16d11bd 
…he mock server

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@patlo-iog
chore: resolve rebase conflict
6a83797
@patlo-iog
chore: resolve rebase conflict
441d474
@patlo-iog
chore: resolve merge compilation conflict
ec586be
@patlo-iog @womfoo
feat: oidc4vc issuer metadata and credential configuration CRUD (#977)
c5de8f2 
Signed-off-by: Kranium Gikos Mendoza <kraniumgikos.mendoza@iohk.io>
Co-authored-by: womfoo <kraniumgikos.mendoza@iohk.io>
@patlo-iog
test: fix test layer make it pass
d2b462b
@patlo-iog
chore: resolve rename conflicts
9085dca
@patlo-iog
chore: resolve rename conflicts
a91b8e7
@coveralls
Copy link

coveralls commented May 6, 2024 •
edited

Coverage Status

coverage: 48.009% (-1.4%) from 49.381%
when pulling c30a244 on oidc
into 3438438 on main.

@patlo-iog
Merge branch 'main' into oidc
160d451 
Signed-off-by: Pat Losoponkul <pat.losoponkul@iohk.io>
@patlo-iog
fix: integrate issuer metadata in oid4vci credential endpoint (#1105)
4eda59a 
Signed-off-by: Pat Losoponkul <pat.losoponkul@iohk.io>
@patlo-iog
ci: fix linter warnings (#1109)
0eff8cb 
Signed-off-by: Pat Losoponkul <pat.losoponkul@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvoiturier bvoiturier Awaiting requested review from bvoiturier bvoiturier is a code owner

@patlo-iog patlo-iog Awaiting requested review from patlo-iog patlo-iog is a code owner

@petevielhaber petevielhaber Awaiting requested review from petevielhaber petevielhaber will be requested when the pull request is marked ready for review petevielhaber is a code owner

@FabioPinheiro FabioPinheiro Awaiting requested review from FabioPinheiro FabioPinheiro will be requested when the pull request is marked ready for review FabioPinheiro is a code owner

@mineme0110 mineme0110 Awaiting requested review from mineme0110 mineme0110 will be requested when the pull request is marked ready for review mineme0110 is a code owner

@shotexa shotexa Awaiting requested review from shotexa shotexa will be requested when the pull request is marked ready for review shotexa is a code owner

@CryptoKnightIOG CryptoKnightIOG Awaiting requested review from CryptoKnightIOG CryptoKnightIOG will be requested when the pull request is marked ready for review CryptoKnightIOG is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
build castor ci cloud-agent docs infra mercury pollux prism-agent shared
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yshyn-iohk @coveralls @atala-dev @patlo-iog