Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Connectionless Verification POC #904

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP Connectionless Verification POC #904

wants to merge 3 commits into from

Conversation

mineme0110
Copy link
Contributor

Overview

Fixes ATL-6420

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

mineme0110 and others added 3 commits February 21, 2024 14:21
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
15 New issues

Measures
0 Security Hotspots
No data about Coverage
2.4% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Integration Test Results

12 files  ±0  12 suites  ±0   2s ⏱️ ±0s
25 tests ±0  25 ✅ ±0  0 💤 ±0  0 ❌ ±0 
26 runs  ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7dd994d. ± Comparison against base commit 4e3aaa3.

Copy link
Contributor

Unit Test Results

 66 files   -  20   66 suites   - 20   16m 15s ⏱️ - 3m 0s
541 tests  - 193  533 ✅  - 193  8 💤 ±0  0 ❌ ±0 
543 runs   - 196  535 ✅  - 196  8 💤 ±0  0 ❌ ±0 

Results for commit 7dd994d. ± Comparison against base commit 4e3aaa3.

This pull request removes 193 tests.
io.iohk.atala.mercury.protocol.presentproof.PresentationSpec ‑ Verifier Presentation
io.iohk.atala.mercury.protocol.presentproof.ProposePresentationSpec ‑ Prover Propose Presentation
io.iohk.atala.mercury.protocol.presentproof.RequestCredentialSpec ‑ Verifier Request Presentation
io.iohk.atala.pollux.core.model.presentation.PresentationAttachmentSpec ‑ Verifier Request Presentation Attachment
io.iohk.atala.pollux.core.model.schema.AnoncredSchemaTypeSpec ‑ AnoncredSchemaTypeTest - should fail for attrName not unique
io.iohk.atala.pollux.core.model.schema.AnoncredSchemaTypeSpec ‑ AnoncredSchemaTypeTest - should fail for having more than 125 attributes
io.iohk.atala.pollux.core.model.schema.AnoncredSchemaTypeSpec ‑ AnoncredSchemaTypeTest - should fail for having null value
io.iohk.atala.pollux.core.model.schema.AnoncredSchemaTypeSpec ‑ AnoncredSchemaTypeTest - should fail for incorrect type
io.iohk.atala.pollux.core.model.schema.AnoncredSchemaTypeSpec ‑ AnoncredSchemaTypeTest - should fail for not having at least 1 attribute
io.iohk.atala.pollux.core.model.schema.AnoncredSchemaTypeSpec ‑ AnoncredSchemaTypeTest - should fail for not having least 1 characters long
…

Copy link
Contributor

@bvoiturier bvoiturier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @mineme0110!! 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider reusing the existing case class (i.e. PresentationStatus) and not duplicate here. I find it confusing for the end-user, and as far as I can see, the only difference is the inner invitation attribute, which is present or not, whether it's an OOB or not. The goal_code and goal attributes at the top are specific to OOB and could easily be exposed as properties of the inner invitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants