-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Connectionless Verification POC #904
base: main
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
Unit Test Results 66 files - 20 66 suites - 20 16m 15s ⏱️ - 3m 0s Results for commit 7dd994d. ± Comparison against base commit 4e3aaa3. This pull request removes 193 tests.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @mineme0110!! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider reusing the existing case class (i.e. PresentationStatus) and not duplicate here. I find it confusing for the end-user, and as far as I can see, the only difference is the inner invitation attribute, which is present or not, whether it's an OOB or not. The goal_code
and goal
attributes at the top are specific to OOB and could easily be exposed as properties of the inner invitation.
Overview
Fixes ATL-6420
Checklist
My PR contains...
My changes...
Documentation
Tests