Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anoncred's createPresentation #752

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FabioPinheiro
Copy link
Contributor

Overview

Fixes for ATL-4887

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@github-actions
Copy link
Contributor

Atala PRISM Test Results

  79 files  ±0    79 suites  ±0   15m 41s ⏱️ +53s
679 tests ±0  668 ✔️ ±0  11 💤 ±0  0 ±0 
685 runs  ±0  674 ✔️ ±0  11 💤 ±0  0 ±0 

Results for commit bb9462c. ± Comparison against base commit 17def3f.

@github-actions
Copy link
Contributor

Integration Test Results

11 files  ±0  11 suites  ±0   3s ⏱️ -1s
25 tests ±0  25 ✔️ ±0  0 💤 ±0  0 ±0 
37 runs  ±0  37 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit bb9462c. ± Comparison against base commit 17def3f.

@BS-IO BS-IO removed the pollux label Nov 28, 2023
@ghost
Copy link

ghost commented Jan 25, 2024

Hey @FabioPinheiro - this PR is quite old - is it still needed or can we close it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants