Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate SD JWT #1016

Merged
merged 5 commits into from
May 29, 2024
Merged

feat: integrate SD JWT #1016

merged 5 commits into from
May 29, 2024

Conversation

FabioPinheiro
Copy link
Contributor

Description:

Start the integrate with SD JWT
Create a module for utility methods and types

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link
Contributor

github-actions bot commented May 6, 2024

Unit Test Results

 93 files  + 2   93 suites  +2   20m 59s ⏱️ + 1m 1s
791 tests +20  783 ✅ +20  8 💤 ±0  0 ❌ ±0 
798 runs  +20  790 ✅ +20  8 💤 ±0  0 ❌ ±0 

Results for commit bc69a73. ± Comparison against base commit 8f55d76.

♻️ This comment has been updated with latest results.

@mineme0110 mineme0110 requested a review from shotexa as a code owner May 20, 2024 12:04
@FabioPinheiro FabioPinheiro changed the title [WIP] feat: integrate SD JWT feat: integrate SD JWT May 27, 2024
Start integration with the agent

More code

WIP

fix the compilation issues

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

added jwt issuer keys

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

convert to ED25519 to pem

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

convert to ED25519 to pem

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

Added domain and challlenge back

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

add holder binding

Signed-off-by: FabioPinheiro <fabiomgpinheiro@gmail.com>

Fixes after new jar

WIP

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP

Just missing public key

fix compilation

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

add another test with holder binding

Signed-off-by: FabioPinheiro <fabiomgpinheiro@gmail.com>

Some more fixes

Signed-off-by: FabioPinheiro <fabiomgpinheiro@gmail.com>

SD JWT moduel is done

Signed-off-by: FabioPinheiro <fabiomgpinheiro@gmail.com>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP

wip

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

cleanup

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

get iss method

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

Add methods for SDJWT

cleanup

Minor fix

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

minor fix

Add method getVerifiedClaims

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

ValidClaims

More type safe

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP progress

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

WIP make is compile =P

Signed-off-by: FabioPinheiro <fabiomgpinheiro@gmail.com>

Compile tests

Signed-off-by: FabioPinheiro <fabiomgpinheiro@gmail.com>

WIP code cleanup

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

minor fix and cleanup

Signed-off-by: FabioPinheiro <fabiomgpinheiro@gmail.com>

WIP code cleanup

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

cleanup

WIP code cleanup

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

Unused imports cleanup

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

Remove Throwable

Code cleanup

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

Improve errors

Run Scalafmt

Allow unpublished holder did

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

remove local resolver

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

allow unpublish did holder

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

add resolvers

scalafmt

fix the test

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>

fix
Signed-off-by: FabioPinheiro <fabiomgpinheiro@gmail.com>
@github-actions github-actions bot added the ci label May 28, 2024
Copy link
Contributor

github-actions bot commented May 28, 2024

Integration Test Results

15 files  ±0  15 suites  ±0   2s ⏱️ ±0s
33 tests ±0  33 ✅ ±0  0 💤 ±0  0 ❌ ±0 
42 runs  ±0  42 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit bc69a73. ± Comparison against base commit 8f55d76.

♻️ This comment has been updated with latest results.

mineme0110 and others added 3 commits May 29, 2024 07:36
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Signed-off-by: FabioPinheiro <fabiomgpinheiro@gmail.com>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
@mineme0110 mineme0110 merged commit 9d7948f into main May 29, 2024
10 checks passed
@mineme0110 mineme0110 deleted the integrate_sd_jwt branch May 29, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants