OpenZeppelin Contracts's SignatureChecker may revert on invalid EIP-1271 signers #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: imhunterand <hostbugbounty1337@gmail.com>
imhunterand
requested review from
awrichar,
peterbroadhurst,
nguyer and
dechdev
as code owners
nguyer
requested changes
Aug 15, 2022
|
Closing for now, due to lack of response. Please feel free to re-open if updated properly. Thanks! |
|
Why this has been closed without merged ? |
|
Hi @imhunterand. I'm happy to reopen it. I requested changes a while ago and the PR feedback was not addressed though. If you'd also like to update |
|
Hi thanks for your respond, could you merged this pls ? Regards |
|
Yes, I'm happy to merge it if you address the changes that I requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SignatureChecker.isValidSignatureNowis not expected to revert. However, an incorrect assumption about Solidity 0.8'sabi.decodeallows some cases to revert, given a target contract that doesn't implement EIP-1271 as expected.The contracts that may be affected are those that use
SignatureCheckerto check the validity of a signature and handle invalid signatures in a way other than reverting. We believe this to be unlikely.Patches
The issue was patched in 4.7.1.
References
OpenZeppelin/openzeppelin-contracts#3552
Additional Information
Please invited my github to contributed/collaborate at your project community.
Regards,