Add argument for base image in Dockerfile #161
Merged
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
awrichar
reviewed
May 21, 2024
| @@ -23,7 +25,7 @@ RUN curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/ | |||
| RUN trivy fs --format spdx-json --output /sbom.spdx.json /SBOM | |||
| RUN trivy sbom /sbom.spdx.json --severity UNKNOWN,HIGH,CRITICAL --exit-code 1 | |||
|
|
|||
| FROM node:20-alpine3.17 | |||
| FROM $BASE_IMAGE | |||
There was a problem hiding this comment.
Feels like maybe we should use the same base image for the other builder phases above (on lines 3 and 11)?
I don't think binary compatibility will be an issue since those steps are only building for Node and EVM. But if someone used a base image other than Node 20 here, for instance... there could definitely be runtime incompatibility.
There was a problem hiding this comment.
Going to add a BUILDER_IMAGE here as I think that makes sense
There was a problem hiding this comment.
Have pushed up this
awrichar
approved these changes
May 21, 2024
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New arg
BASE_IMAGEfor Dockerfile