Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(lerna): evaluate lerna-lite migration #2005

Merged
merged 1 commit into from Jul 21, 2022
Merged

build(lerna): evaluate lerna-lite migration #2005

merged 1 commit into from Jul 21, 2022

Conversation

johnhomantaring
Copy link
Contributor

Fixes #1890

Signed-off-by: johnhomantaring john.h.o.mantaring@accenture.com

@johnhomantaring
Copy link
Contributor Author

Already doen with initial changes and lerna-lite is running properly:
image
image

@johnhomantaring
Copy link
Contributor Author

johnhomantaring commented May 16, 2022 •
edited

--signoff is now supported as new packages has been created https://github.com/ghiscoding/lerna-lite..
image

I just removed lerna clean and lerna boostrap as they are not supported by lerna-lite by I think "run ci" is not being used as well.
image

@johnhomantaring johnhomantaring force-pushed the johnhomantaring/cactus#1870 branch 2 times, most recently from 61d1d9a to 0be5dde Compare May 16, 2022 17:09
@johnhomantaring johnhomantaring marked this pull request as ready for review May 16, 2022 17:13
@petermetz petermetz requested review from izuru0 and takeutak and removed request for jonathan-m-hamilton May 17, 2022 01:21
petermetz
petermetz requested changes May 17, 2022
View reviewed changes
Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnhomantaring Please fix the failing checks (build-node-16)

@petermetz
Copy link
Member

@johnhomantaring Take a look at https://github.com/ghiscoding/lerna-lite/blob/main/packages/core/src/package-graph/package-graph.ts and it's usage examples in the lerna-lite tests to see how you could replace ./node_modules/.bin/lerna list --all --json --toposort with some code that does the same thing.

@johnhomantaring
Copy link
Contributor Author

build-node-16 is failing due to "lerna list" as of last week this is not yet supported by lerna-lite. Already asked the dev if there is a roadmap that they would this as an option. Initially they've mentioned "No" but yesterday I was informed by the maintainer of lerna-lite that an optional feature for lerna list would be added. I will just monitor PR once merged so I could continue testing lerna-lite and fix the failing build.

@johnhomantaring johnhomantaring force-pushed the johnhomantaring/cactus#1870 branch 2 times, most recently from 749c25c to 0d1434a Compare May 31, 2022 13:46
@johnhomantaring johnhomantaring marked this pull request as draft May 31, 2022 16:12
ghiscoding
ghiscoding reviewed May 31, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@johnhomantaring johnhomantaring force-pushed the johnhomantaring/cactus#1870 branch 3 times, most recently from 155024f to 7c0ae7a Compare June 2, 2022 00:30
@petermetz petermetz marked this pull request as ready for review June 2, 2022 00:38
@johnhomantaring johnhomantaring marked this pull request as draft June 2, 2022 07:18
@petermetz petermetz marked this pull request as ready for review June 16, 2022 16:02
@johnhomantaring
Copy link
Contributor Author

Depends on #2096

@petermetz
Copy link
Member

Depends on #2096

@johnhomantaring You have to put the dependency declaration in the PR description. The bot won't scan the comments for it.

petermetz
petermetz approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnhomantaring LGTM, thank you!

petermetz
petermetz requested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnhomantaring Please resolve the merge conflicts and then we are good to go once again!

@johnhomantaring johnhomantaring force-pushed the johnhomantaring/cactus#1870 branch 3 times, most recently from 175d250 to 8775d2a Compare July 20, 2022 03:42
petermetz
petermetz approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnhomantaring LGTM, thank you!

@johnhomantaring @petermetz
build(lerna): evaluate lerna-lite migration
10c43ec 
Fixes hyperledger#1890
Depends on hyperledger#2096

Signed-off-by: john.h.o.mantaring-at-475704139995 <john.h.o.mantaring@accenture.com>
@petermetz petermetz force-pushed the johnhomantaring/cactus#1870 branch from 20de830 to 10c43ec Compare July 20, 2022 17:14
@petermetz petermetz merged commit 31a5774 into hyperledger:main Jul 21, 2022
@petermetz petermetz deleted the johnhomantaring/cactus#1870 branch July 21, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghiscoding ghiscoding ghiscoding left review comments

@petermetz petermetz petermetz approved these changes

@jagpreetsinghsasan jagpreetsinghsasan jagpreetsinghsasan approved these changes

@izuru0 izuru0 Awaiting requested review from izuru0 izuru0 is a code owner

@takeutak takeutak Awaiting requested review from takeutak takeutak is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build(lerna): evaluate lerna-lite migration
4 participants
@johnhomantaring @petermetz @ghiscoding @jagpreetsinghsasan