Replace failure crate with thiserror

[mirgee]

Replaces the dependency on outdated failure crate with the dependency on thiserror in messages, aries-vcx-agent, aries-vcx and libvcx. Although our entire approach to logging needs to be reconsidered, removing a dependency on an unmaintained crate is likely not a step in the wrong direction.

It seems that we have to temporarily give up backtrace in libvcx errors stored in CURRENT_ERROR_C_JSON until error_generic_member_access is stabilized since thiserror makes use of unstable provide() method to the error type in order to capture and share std::backtrace::Backtrace.

[codecov-commenter]

Codecov Report

Merging #684 (619c697) into main (aa4aed2) will increase coverage by 19.81%.
The diff coverage is 16.66%.

@@             Coverage Diff             @@
##             main     #684       +/-   ##
===========================================
+ Coverage   42.66%   62.48%   +19.81%     
===========================================
  Files         234      237        +3     
  Lines       17824    23134     +5310     
  Branches     3521     5276     +1755     
===========================================
+ Hits         7605    14455     +6850     
+ Misses       7905     4551     -3354     
- Partials     2314     4128     +1814     

Flag	Coverage Δ
unittests-aries-vcx	62.34% <16.66%> (+19.68%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aries_vcx/src/common/ledger/transactions.rs	51.89% <0.00%> (+35.23%)	⬆️
aries_vcx/src/indy/ledger/transactions.rs	50.00% <0.00%> (+40.65%)	⬆️
aries_vcx/src/utils/serialization.rs	0.00% <0.00%> (ø)
agency_client/src/error.rs	18.42% <5.00%> (+8.66%)	⬆️
aries_vcx/src/error.rs	14.57% <22.72%> (+1.35%)	⬆️
messages/src/error.rs	5.00% <23.07%> (-1.09%)	⬇️
aries_vcx/src/indy/signing.rs	60.34% <100.00%> (ø)
aries_vcx/tests/test_connection.rs	73.23% <0.00%> (-26.77%)	⬇️
aries_vcx/tests/test_pool.rs	76.82% <0.00%> (-23.18%)	⬇️
aries_vcx/tests/test_agency.rs	80.90% <0.00%> (-19.10%)	⬇️
... and 149 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Patrik-Stas]

@mirgee awesome! But I please rebase on #648 rather soon then later ;-) It's going to be the next going to be the next merge to main followed by 0.50.0 release right after

[Patrik-Stas]

It's also great that indy-vdr and indy-shared-rs are both using thiserror

We'll just need rebase this