This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: out of band messaging #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudeshrshetty
force-pushed
the
0.1.3
branch
2 times, most recently
from
0642815
to
dd199e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
==========================================
- Coverage 91.28% 91.28% -0.01%
==========================================
Files 139 139
Lines 9228 9257 +29
==========================================
+ Hits 8424 8450 +26
- Misses 455 457 +2
- Partials 349 350 +1
Continue to review full report at Codecov.
|
llorllale
reviewed
Mar 9, 2020
.golangci.yml
Outdated
| @@ -71,7 +71,7 @@ linters-settings: | |||
| - unnamedResult | |||
| - whyNoLint # TODO enable. | |||
| funlen: | |||
| lines: 60 | |||
| lines: 100 | |||
There was a problem hiding this comment.
Suggested change
| lines: 100 | |
| lines: 60 |
- message service command controller to use messanger api - send message to support out of band messages - Part of hyperledger-archives#1058 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
rolsonquadras
approved these changes
Mar 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sudesh.shetty sudesh.shetty@securekey.com