Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Decouple NamedService from the transport feature #969

Merged
merged 4 commits into from Jun 21, 2022

Commits on Apr 9, 2022

  1. Decouple NamedService from the transport feature

    The `tonic::transport::NamedService` trait is gated by the `transport`
    feature. This means that generated server implementations can only
    include this implementation when the `transport` feature is enabled on
    `tonic-build`; and if the `transport` feature is not used at
    generation-time, then a server cannot be used with
    `tonic::transport::Server` at runtime.
    
    We would like to publish a crate including generated protobuf/gRPC
    bindings that does not _require_ a dependency on the `transport` feature
    (and its fairly heavyweight dependency tree). But it would be nice if
    its servers could still be used by applications that want to use
    `tonic::transport::Server`.
    
    By decoupling the `NamedService` trait from the `transport` feature,
    `tonic-build` can be changed to always provide an implementation for
    this trait without requiring all of the `transport` dependencies. This
    enables generated servers to be used with `tonic::transport::Server`.
    olix0r committed Apr 9, 2022
    Copy the full SHA
    d432290 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Copy the full SHA
    2062312 View commit details
    Browse the repository at this point in the history
  2. fix wrong path to NamedService

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    hawkw committed Jun 21, 2022
    Copy the full SHA
    0575b9b View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1 from hawkw/ver/build-no-transport

    fix & update hyperium/tonic/hyperium#969
    olix0r committed Jun 21, 2022
    Copy the full SHA
    41eeac3 View commit details
    Browse the repository at this point in the history