feat(build): Expose Prost generation plugin #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing such plugin allows independent code generators (outside of the vanilla `build.rs` workflow) to use tonic-build to get gRPC code generation. This paves the way for a `protoc-gen-tonic` plugin, opening integration in e.g. buf.
LucioFranco
reviewed
Mar 29, 2022
This simplifies the code as it allows to simply write `configure() /* opts */ .service_generator()`.
LucioFranco
approved these changes
Mar 31, 2022
LucioFranco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing such plugin allows independent code generators (outside of the vanilla
build.rsworkflow) to use tonic-build to get gRPC code generation. This paves the way for aprotoc-gen-tonicplugin, opening integration in e.g. buf.And indeed, you can find the plugin over here: https://github.com/Tuetuopay/protoc-gen-tonic
This builds on my work on
protoc-gen-prost, and allows integration in the wider protoc/buf/... ecosystem. You can read more on the motivation for such a change over on tokio-rs/prost#492, and more about the features in the prost plugin repository. The tonic plugin inherits from all nice features (like crate gen) from the prost plugin.