Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transport): Make server builder more consitient #901

Merged
merged 2 commits into from Feb 18, 2022
Merged

fix(transport): Make server builder more consitient #901

merged 2 commits into from Feb 18, 2022

Commits on Feb 18, 2022

  1. tonic: fix consistency issue with timeout func in transport/server bu… 

    …ilder

transport/server/mod.rs exposes a Builder for the Server, and most of the
Builder functions return Self (a change made for issue hyperium#115), but timeout
returns mut& Self. This change makes timeout consistent with the rest of
the Builder api by returning Self.

Fixes: hyperium#900
Refs: hyperium#115
    @jdahlq
    jdahlq committed Feb 18, 2022
    Copy the full SHA
    cf919de View commit details
    Browse the repository at this point in the history

  2. tonic: add must_use annotations to Server builder methods which retur… 

    …n Self
    @jdahlq
    jdahlq committed Feb 18, 2022
    Copy the full SHA
    b95117d View commit details
    Browse the repository at this point in the history