Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport): AddOrigin panic on invalid uri #801

Merged
merged 1 commit into from
Oct 22, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 14 additions & 4 deletions tonic/src/transport/service/add_origin.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use futures_core::future::BoxFuture;
use http::{Request, Uri};
use std::task::{Context, Poll};
use tower_service::Service;
Expand All @@ -17,13 +18,15 @@ impl<T> AddOrigin<T> {
impl<T, ReqBody> Service<Request<ReqBody>> for AddOrigin<T>
where
T: Service<Request<ReqBody>>,
T::Future: Send + 'static,
T::Error: Into<crate::Error>,
{
type Response = T::Response;
type Error = T::Error;
type Future = T::Future;
type Error = crate::Error;
type Future = BoxFuture<'static, Result<Self::Response, Self::Error>>;

fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
self.inner.poll_ready(cx)
self.inner.poll_ready(cx).map_err(Into::into)
}

fn call(&mut self, req: Request<ReqBody>) -> Self::Future {
Expand All @@ -34,6 +37,11 @@ where
let mut uri: http::uri::Parts = head.uri.into();
let set_uri = self.origin.clone().into_parts();

if set_uri.scheme.is_none() || set_uri.authority.is_none() {
let err = crate::transport::Error::new_invalid_uri();
return Box::pin(async move { Err::<Self::Response, _>(err.into()) });
}

// Update the URI parts, setting hte scheme and authority
uri.scheme = Some(set_uri.scheme.expect("expected scheme"));
uri.authority = Some(set_uri.authority.expect("expected authority"));
Expand All @@ -43,6 +51,8 @@ where

let request = Request::from_parts(head, body);

self.inner.call(request)
let fut = self.inner.call(request);

Box::pin(async move { fut.await.map_err(Into::into) })
}
}