chore(codegen): Deprecate _Inner<T>. #1647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
reviewed
Mar 4, 2024
gibbz00
force-pushed
the
deprecate_inner
branch
4 times, most recently
from
caa06e1
to
d2d5817
Compare
Removes a redundant clone in the `tower-service::Service::call()` implementation, and reduces the amount of generated code. Does not break any user facing API.
|
Looks good to me. I would think this simplifies As this does not affect the public APIs of generated codes, this seems not to be a breaking change. |
tottoto
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a redundant clone in the
tower-service::Service::call()implementation, and reduces the amount of generated code. Does not break any user facing API.Don't know how much the removed clone matters in practice. Perhaps it gets optimized away during compilation regardless 馃檲