Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transport): add from_listener for TcpIncoming #1093

Merged
merged 2 commits into from
Oct 3, 2022
Merged

feat(transport): add from_listener for TcpIncoming #1093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d28ed6f
feat(transport): add `from_listener` for `TcpIncoming`
w41ter Sep 29, 2022
062982d
fixup
w41ter Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 16 additions & 1 deletion tonic/src/transport/server/incoming.rs
View file
Open in desktop
Expand Up @@ -12,7 +12,10 @@ use std::{
task::{Context, Poll},
time::Duration,
};
use tokio::io::{AsyncRead, AsyncWrite};
use tokio::{
io::{AsyncRead, AsyncWrite},
net::TcpListener,
};

#[cfg(not(feature = "tls"))]
pub(crate) fn tcp_incoming<IO, IE, L>(
Expand Down Expand Up @@ -172,6 +175,18 @@ impl TcpIncoming {
inner.set_keepalive(keepalive);
Ok(TcpIncoming { inner })
}

/// Creates a new `TcpIncoming` from an existing `tokio::net::TcpListener`.
pub fn from_listener(
listener: TcpListener,
nodelay: bool,
keepalive: Option<Duration>,
) -> Result<Self, crate::Error> {
let mut inner = AddrIncoming::from_listener(listener)?;
inner.set_nodelay(nodelay);
inner.set_keepalive(keepalive);
Ok(TcpIncoming { inner })
}
}

impl Stream for TcpIncoming {
Expand Down