Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): Add gRPC Richer Error Model support (BadRequest) #1068

Merged
merged 6 commits into from Sep 21, 2022
Merged

feat(types): Add gRPC Richer Error Model support (BadRequest) #1068

merged 6 commits into from Sep 21, 2022

Commits on Aug 26, 2022

  1. types: add tonic as dependency, add error_details.proto

    @flemosr
    flemosr committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    47465a6 View commit details
    Browse the repository at this point in the history

  2. types: add BadRequest support from flemosr/tonic-richer-error

    @flemosr
    flemosr committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    dffa044 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2022

  1. types: adjust code following suggestions 

    Adjustments following suggestions by @LucioFranco in hyperium#1068.

Adjust style, remove unecessary prints, avoid glob imports, apply
`non_exhaustive` to `ErrorDetails` and `ErrorDetail`, avoid pub
fields in `ErrorDetails`, adjust
`WithErrorDetails::with_error_details_vec` args, add
`gen_details_bytes`.
    @flemosr
    flemosr committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    6091bb2 View commit details
    Browse the repository at this point in the history

  2. types: add generated protobuf code 

    As suggested by @LucioFranco in hyperium#1068 (comment).

This avoids the need for consumers to have `protoc` in their path.
Implemented following changes in hyperium#1065.
    @flemosr
    flemosr committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    67379ae View commit details
    Browse the repository at this point in the history

  3. types: add custom metadata support 

    This allows consumers to provide custom metadata when creating a
`Status` with error details.
    @flemosr
    flemosr committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    c10ded7 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. types: adjust code following suggestions 

    Adjustments following suggestions by @LucioFranco in hyperium#1068.

Move `error_details_vec` mod into `error_details` mod, adjust doc
comments, rename `WithErrorDetails` trait to `StatusExt`.
    @flemosr
    flemosr committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    9f7ecfb View commit details
    Browse the repository at this point in the history