Customization of whether server date headers are sent #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharmath
approved these changes
Apr 23, 2024
seanmonstar
reviewed
Apr 26, 2024
|
@seanmonstar auto_date_header does make more sense! |
seanmonstar
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially starting with issue #912 then followed up with pull request #2751, this pull request addresses the need for customizing whether the server sends the
dateheader for http/2 and http/1.1.According to RFC7231#7.1.1.2, it is not always preferable to send the
dateheader if the system may not have access to time or may not be accurate. Additionally, disabling thedateheader will result in slight performance gains.This pull request aims to allow users to customize when building the http1 or http2 service whether the date headers should be sent in responses, with a similar API to other boolean options. It also integrates tests for both http1 and 2 to prevent regression.
If you have suggestions, questions, comments, please comment on this pull request! I will promptly make changes.
Have an incredible rest of your day.