Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http1): improve debug messages when sending trailers #3641

Merged
merged 1 commit into from
Apr 20, 2024

Commits on Apr 20, 2024

  1. fix(http1): improve debug messages when sending trailers

    When the "trailer" header was not found in the response, the debug
    message would say "attempted to encode trailers for non-chunked
    response". This was quite misleading as the response was chunked. We
    now include a better debug message that hints to the user that the
    "trailer" header was not specified.
    
    When a chunked response contained a trailer header that did not match
    the header names specified in the "trailer" response header, there was
    no debug message to the user. We now include debug messages that tell
    the user if the header name is not allowed and if the header name was
    not specified in the "trailer" response header.
    hjr3 committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    fe1de7f View commit details
    Browse the repository at this point in the history