Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not include user information in Host header #3621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Do not include user information in Host header #3621

wants to merge 1 commit into from

Commits on Apr 5, 2024

  1. fix: Do not include user information in Host header 

    According to RFC 9110, section 7.2, the Host header should only comprise
the URI host and an optional port.

Currently, the examples set the Host header to the URI's authority which
may also contain user information (see RFC 3986, section 3.2).

Update the examples to construct the Host header manually to avoid
sensitive information from showing up in server logs and to ensure that
the server's routing logic works correctly when a username and password
are supplied.
    @tindzk
    tindzk committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2b3cc9f View commit details
    Browse the repository at this point in the history