Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: optimize error type #3596

Closed
wants to merge 2 commits into from
Closed

perf: optimize error type #3596

wants to merge 2 commits into from
+53 −16

Commits on Mar 7, 2024

  1. perf: don't box ErrorImpl 

    We don't seem to need this boxed, and the allocs and frees do actually cost us a fair bit in prod according to my flamegraphs.
    @Noah-Kennedy
    Noah-Kennedy committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    1eaca8d View commit details
    Browse the repository at this point in the history

  2. perf: don't box cause for h2 errors 

    This seems to be costly as well for some applications, so let's avoid boxing unless we need to.
    @Noah-Kennedy
    Noah-Kennedy committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    82df42d View commit details
    Browse the repository at this point in the history