Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): run connect_to to completion even if ResponseFuture is canceled #3205

Open
wants to merge 5 commits into
base: 0.14.x
Choose a base branch
from

Commits on Apr 18, 2023

  1. fix(client): run connect_to to completion even if ResponseFuture

    …is canceled
    
    In the previous implementation the `connect_to` future was spawned to let it finish when the checkout future won the race. However, in the event of the user dropping the `ResponseFuture`, the `connect_to` future was canceled as well, and all the http2 requests waiting for the connection would error as a result. This commit prevents that by spawning the `connect_to` future invariably (once it starts) thus covering both cases.
    
    Fixes hyperium#3199
    arnauorriols committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    71541a2 View commit details
    Browse the repository at this point in the history
  2. Merge branch '0.14.x' into when_request_is_cancelled_connecting_task_…

    …is_inherited_by_next_request
    arnauorriols committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    14b9996 View commit details
    Browse the repository at this point in the history
  3. Fix fmt

    arnauorriols committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    ea3fdb7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    241a0ff View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Configuration menu
    Copy the full SHA
    fa3e220 View commit details
    Browse the repository at this point in the history