Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: assorted code readability improvements in h1/conn.rs #2817

Merged
merged 13 commits into from Apr 26, 2022
Merged

Refactor: assorted code readability improvements in h1/conn.rs #2817

merged 13 commits into from Apr 26, 2022

Commits on Apr 24, 2022

  1. refactor: use matches macro to flatten code

    @BastiDood
    BastiDood committed Apr 24, 2022
    Copy the full SHA
    a55946c View commit details
    Browse the repository at this point in the history

  2. refactor: prefer matches over explicit matching

    @BastiDood
    BastiDood committed Apr 24, 2022
    Copy the full SHA
    aeda230 View commit details
    Browse the repository at this point in the history

  3. refactor: reuse can_write_body method

    @BastiDood
    BastiDood committed Apr 24, 2022
    Copy the full SHA
    5865910 View commit details
    Browse the repository at this point in the history

  4. refactor: use matches over if-let

    @BastiDood
    BastiDood committed Apr 24, 2022
    Copy the full SHA
    38601c3 View commit details
    Browse the repository at this point in the history

  5. refactor: nested if-else as early return

    @BastiDood
    BastiDood committed Apr 24, 2022
    Copy the full SHA
    83691fc View commit details
    Browse the repository at this point in the history

  6. refactor: move inner match logic outside

    @BastiDood
    BastiDood committed Apr 24, 2022
    Copy the full SHA
    530ebc2 View commit details
    Browse the repository at this point in the history

  7. refactor: unneeded return in match

    @BastiDood
    BastiDood committed Apr 24, 2022
    Copy the full SHA
    e1cd9c5 View commit details
    Browse the repository at this point in the history

  8. refactor: remove unneeded reference matching

    @BastiDood
    BastiDood committed Apr 24, 2022
    Copy the full SHA
    8530a59 View commit details
    Browse the repository at this point in the history

  9. refactor: use early returns for idle check

    @BastiDood
    BastiDood committed Apr 24, 2022
    Copy the full SHA
    36b62f2 View commit details
    Browse the repository at this point in the history

  10. refactor: use matches macro for Boolean match

    @BastiDood
    BastiDood committed Apr 24, 2022
    Copy the full SHA
    da23775 View commit details
    Browse the repository at this point in the history

  11. fix: remove accidentally introduced semicolon

    @BastiDood
    BastiDood committed Apr 24, 2022
    Copy the full SHA
    8817396 View commit details
    Browse the repository at this point in the history

  12. fix: revert removal of references 

    It turns out `Copy` was not implemented. Oops!
    @BastiDood
    BastiDood committed Apr 24, 2022
    Copy the full SHA
    7aab0f7 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. revert: use explicit pattern-matching for some cases

    @BastiDood
    BastiDood committed Apr 26, 2022
    Copy the full SHA
    e0f639c View commit details
    Browse the repository at this point in the history