Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(capi): make early returns consistent in C examples #2812

Merged
merged 7 commits into from Apr 12, 2022
Merged

Refactor(capi): make early returns consistent in C examples #2812

merged 7 commits into from Apr 12, 2022

Commits on Apr 11, 2022

  1. refactor(capi): prefer early returns for read_cb

    @BastiDood
    BastiDood committed Apr 11, 2022
    Copy the full SHA
    2e5fb40 View commit details
    Browse the repository at this point in the history

  2. refactor(capi): prefer early returns for write_cb

    @BastiDood
    BastiDood committed Apr 11, 2022
    Copy the full SHA
    95e86bd View commit details
    Browse the repository at this point in the history

  3. refactor(capi): remove redundant else after break 

    Since the `if` condition already causes the loop to `break`,
the `else` is not necessary. We wouldn't have reached the `else`
block, anyway, if the prior `if` condition passed.
    @BastiDood
    BastiDood committed Apr 11, 2022
    Copy the full SHA
    851bee7 View commit details
    Browse the repository at this point in the history

  4. format(capi): fix some irregular spacing an indentation

    @BastiDood
    BastiDood committed Apr 11, 2022
    Copy the full SHA
    08d6664 View commit details
    Browse the repository at this point in the history

  5. refactor(capi): remove unneeded else block

    @BastiDood
    BastiDood committed Apr 11, 2022
    Copy the full SHA
    e95a758 View commit details
    Browse the repository at this point in the history

  6. refactor(capi): reorder result check for poll_req_upload 

    We are more likely to poll a successful chunk than finish
the request or throw an error. Thus, it is best if we go
for the optimistic route and check for the successful
case first.
    @BastiDood
    BastiDood committed Apr 11, 2022
    Copy the full SHA
    9e1bf4f View commit details
    Browse the repository at this point in the history

  7. refactor(capi): remove another unneeded else after break

    @BastiDood
    BastiDood committed Apr 11, 2022
    Copy the full SHA
    b272ee9 View commit details
    Browse the repository at this point in the history