Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move non-conn code out of conn.rs #2775

Merged
merged 3 commits into from Apr 9, 2022
Merged

Move non-conn code out of conn.rs #2775

merged 3 commits into from Apr 9, 2022

Commits on Mar 12, 2022

  1. refactor(server): move non-conn code out of conn.rs 

    The actual code for `Server` was previously organized very confusingly:
it was thrice layered with `SpawnAll` and `Serve` which both appeared in
conn.rs despite not having anything to do with the lower-level conn API.
This commit changes that, removing all layering and having the code for
the higher-level `Server` appear inside `server.rs` only.
    @SabrinaJewson
    SabrinaJewson committed Mar 12, 2022
    Copy the full SHA
    f6c9707 View commit details
    Browse the repository at this point in the history

  2. refactor(server): simplify server cfgs 

    `server.rs` is currently littered with `cfg`s for `http1` or `http2`,
since the majority of server behaviour is only available with either one
of those feature flags active. This is hard to maintain and confusing to
read, so this commit extracts the two implementations into their own
files, since there is very little benefit in sharing code between the
two.
    @SabrinaJewson
    SabrinaJewson committed Mar 12, 2022
    Copy the full SHA
    43bc602 View commit details
    Browse the repository at this point in the history

  3. style(server): rustfmt

    @SabrinaJewson
    SabrinaJewson committed Mar 12, 2022
    Copy the full SHA
    ff4c8cc View commit details
    Browse the repository at this point in the history