Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rt): introduce rt::Executor trait #2032

Merged
merged 1 commit into from Dec 4, 2019
Merged

feat(rt): introduce rt::Executor trait #2032

merged 1 commit into from Dec 4, 2019

Conversation

seanmonstar
Copy link
Member

The hyper::rt::Executor trait allows defining custom executors to be
used with hyper's Client and Server.

Closes #1944

BREAKING CHANGE: Any type passed to the executor builder methods must
now implement hyper::rt::Executor.

hyper::rt::spawn usage should be replaced with tokio::task::spawn.

hyper::rt::run usage should be replaced with #[tokio::main] or
managing a tokio::runtime::Runtime manually.

The `hyper::rt::Executor` trait allows defining custom executors to be
used with hyper's `Client` and `Server`.

Closes #1944

BREAKING CHANGE: Any type passed to the `executor` builder methods must
  now implement `hyper::rt::Executor`.

  `hyper::rt::spawn` usage should be replaced with `tokio::task::spawn`.

  `hyper::rt::run` usage should be replaced with `#[tokio::main]` or
  managing a `tokio::runtime::Runtime` manually.
@seanmonstar seanmonstar merged commit 6ae5889 into master Dec 4, 2019
@seanmonstar seanmonstar deleted the rt-executor branch December 4, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client builder's executor setter is confusing for new tokio 0.2 alpha
1 participant