Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): rename Service to HttpService, re-export tower::Service` #1985

Merged
merged 1 commit into from Oct 21, 2019

Conversation

seanmonstar
Copy link
Member

The only important trait for a user is the tower::Service trait, which
is now available also at hyper::service::Service. The other "trait
aliases" are no longer publicly exported, as people thought they had to
implement them.

Also removes dependency on tower-make, which is trivial but otherwise
shouldn't affect anyone.

Closes #1959

…rvice`

The only important trait for a user is the `tower::Service` trait, which
is now available also at `hyper::service::Service`. The other "trait
aliases" are no longer publicly exported, as people thought they had to
implement them.

Also removes dependency on `tower-make`, which is trivial but otherwise
shouldn't affect anyone.

Closes #1959
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if losing tower-makes much of a difference but this seems fine.

@seanmonstar seanmonstar merged commit 4f27439 into master Oct 21, 2019
@seanmonstar seanmonstar deleted the http-service branch October 21, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddrListener should accept IntoSocketAddrs
2 participants