fix(server): ignore expect-continue with no body in debug mode #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Oct 18, 2019
| @@ -151,7 +151,9 @@ where I: AsyncRead + AsyncWrite + Unpin, | |||
| self.state.version = msg.head.version; | |||
|
|
|||
| if msg.decode == DecodedLength::ZERO { | |||
| debug_assert!(!msg.expect_continue, "expect-continue needs a body"); | |||
| if log_enabled!(log::Level::Debug) && msg.expect_continue { | |||
There was a problem hiding this comment.
The log_enabled! here doesn't seem necessary, since there's no expensive computation going on in the block.
There was a problem hiding this comment.
True... I guess with max-log-level features, it could then just be eliminated... But I guess LLVM would also be able to eliminate if some_bool { /* nothing */ }. 🤷♂
There was a problem hiding this comment.
Yeah empty if blocks will go away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1843