Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add initial window builder methods that take self by-val #1817

Merged
merged 2 commits into from May 16, 2019

Conversation

seanmonstar
Copy link
Member

The current Builder methods http2_initial_stream_window_size and
http2_initial_connection_window_size take &mut self, while every
other builder method takes self. That breaks up the chaining of
options.

This patch adds two methods that configure the same option, but take
self instead, and have an underscore suffix (so,
http2_initial_stream_window_size_).

cc #1814

The current `Builder` methods `http2_initial_stream_window_size` and
`http2_initial_connection_window_size` take `&mut self`, while every
other builder method takes `self`. That breaks up the chaining of
options.

This patch adds two methods that configure the same option, but take
`self` instead, and have an underscore suffix (so,
`http2_initial_stream_window_size_`).

cc #1814
@seanmonstar
Copy link
Member Author

@sfackler any thoughts on whether the previous methods should get #[deprecated] attributes? Or is hiding them from docs enough?

@sfackler
Copy link
Contributor

I don't feel super strongly about deprecation. There's nothing wrong with using the old methods...

@seanmonstar seanmonstar merged commit 8b45af7 into master May 16, 2019
@seanmonstar seanmonstar deleted the server-builder-http2-window branch May 16, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants