feat(server): re-design Server as higher-level API
#1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
commented
Apr 16, 2018
examples/hello.rs
Outdated
| .bind(&addr, new_service) | ||
| .unwrap(); | ||
| let server = Server::bind(&addr) | ||
| .expect("bind to address") |
There was a problem hiding this comment.
I'm strongly considering making the default Server::bind either a) panic if binding errors, or b) lazily binding on the first poll of the Server. Forcing users to deal with an error that isn't likely to happen every single time feels like an annoying speed bump. Anyone wanting to handle a bind error can bind a TcpListener themselves, and use Builder::new.
src/server/mod.rs
Outdated
| } | ||
| #[deprecated(note="import from hyper::server::conn, or consider hyper::Server")] | ||
| #[doc(hidden)] | ||
| pub type Http = Http_; |
There was a problem hiding this comment.
I'm undecided on whether to keep this, or remove it. I did this since it allowed providing a hint in the message that things have changed, instead of simply hyper::server::Http is private. But it may be annoying to keep around for all of 0.12.x...
seanmonstar
force-pushed
the
server2
branch
4 times, most recently
from
4fa759f
to
67010fb
Compare
The `hyper::Server` is now a proper higher-level API for running HTTP servers. There is a related `hyper::server::Builder` type, to construct a `Server`. All other types (`Http`, `Serve`, etc) were moved into the "lower-level" `hyper::server::conn` module. The `Server` is a `Future` representing a listening HTTP server. Options needed to build one are set on the `Builder`. As `Server` is just a `Future`, it no longer owns a thread-blocking executor, and can thus be run next to other servers, clients, or what-have-you. Closes #1322 Closes #1263 BREAKING CHANGE: The `Server` is no longer created from `Http::bind`, nor is it `run`. It is a `Future` that must be polled by an `Executor`. The `hyper::server::Http` type has move to `hyper::server::conn::Http`.
This was referenced Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hyper::Serveris now a proper higher-level API for running HTTPservers. There is a related
hyper::server::Buildertype, to constructa
Server. All other types (Http,Serve, etc) were moved into the"lower-level"
hyper::server::connmodule.The
Serveris aFuturerepresenting a listening HTTP server. Optionsneeded to build one are set on the
Builder.As
Serveris just aFuture, it no longer owns a thread-blockingexecutor, and can thus be run next to other servers, clients, or
what-have-you.
Closes #1322
Closes #1263
BREAKING CHANGE: The
Serveris no longer created fromHttp::bind,nor is it
run. It is aFuturethat must be polled by anExecutor.The
hyper::server::Httptype has move tohyper::server::conn::Http.