Skip to content

Commit

Permalink
fix(http2): "Trailer" header should be allowed in HTTP/2 responses as…
Browse files Browse the repository at this point in the history
… per RFC 9110
  • Loading branch information
Qishuai Liu committed Apr 25, 2024
1 parent 226305d commit 31c7257
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions src/proto/h2/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use std::task::{Context, Poll};
use bytes::{Buf, Bytes};
use futures_util::ready;
use h2::{Reason, RecvStream, SendStream};
use http::header::{HeaderName, CONNECTION, TE, TRAILER, TRANSFER_ENCODING, UPGRADE};
use http::header::{HeaderName, CONNECTION, TE, TRANSFER_ENCODING, UPGRADE};
use http::HeaderMap;
use pin_project_lite::pin_project;

Expand All @@ -31,15 +31,13 @@ cfg_server! {
/// Default initial stream window size defined in HTTP2 spec.
pub(crate) const SPEC_WINDOW_SIZE: u32 = 65_535;

// List of connection headers from:
// https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection
// List of connection headers from RFC 9110 Section 7.6.1
//
// TE headers are allowed in HTTP/2 requests as long as the value is "trailers", so they're
// tested separately.
static CONNECTION_HEADERS: [HeaderName; 5] = [
static CONNECTION_HEADERS: [HeaderName; 4] = [
HeaderName::from_static("keep-alive"),
HeaderName::from_static("proxy-connection"),
TRAILER,
TRANSFER_ENCODING,
UPGRADE,
];
Expand Down

0 comments on commit 31c7257

Please sign in to comment.