Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix html_root_url #688

Merged
merged 2 commits into from Mar 13, 2024
Merged

Fix html_root_url #688

merged 2 commits into from Mar 13, 2024

Conversation

LukeMathWalker
Copy link
Contributor

No description provided.

@LukeMathWalker
Copy link
Contributor Author

Although an actual fix requires setting it to 0.2.13 and cutting a new release.
What is the purpose of setting the attribute in the first place?

@seanmonstar
Copy link
Member

It's legacy. Docs now have a good default, we can remove the attribute.

@LukeMathWalker
Copy link
Contributor Author

Done in 0b1d17b 👍🏻

@seanmonstar seanmonstar merged commit 0bb8125 into hyperium:0.2.x Mar 13, 2024
5 checks passed
@LukeMathWalker LukeMathWalker deleted the patch-1 branch March 13, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LukeMathWalker @seanmonstar