Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using as_u16 in const contexts #680

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow using as_u16 in const contexts #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b8cc85
Allow using StatusCode::as_u16 in const contexts
WhyNotHugo Feb 21, 2024
caf471b
Allow using Port::as_u16 in const contexts
WhyNotHugo Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/status.rs
View file
Open in desktop
Expand Up @@ -116,8 +116,8 @@ impl StatusCode {
/// assert_eq!(status.as_u16(), 200);
/// ```
#[inline]
pub fn as_u16(&self) -> u16 {
(*self).into()
pub const fn as_u16(&self) -> u16 {
(*self).0.get()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hint for reviewers: into() did exactly this under the hood.

}

/// Returns a &str representation of the `StatusCode`
Expand Down
2 changes: 1 addition & 1 deletion src/uri/port.rs
View file
Open in desktop
Expand Up @@ -22,7 +22,7 @@ impl<T> Port<T> {
/// let port = authority.port().unwrap();
/// assert_eq!(port.as_u16(), 80);
/// ```
pub fn as_u16(&self) -> u16 {
pub const fn as_u16(&self) -> u16 {
self.port
}
}
Expand Down