Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lib): move request and response trait bound assertion to test #676

Merged
merged 1 commit into from Feb 16, 2024
Merged

refactor(lib): move request and response trait bound assertion to test #676

merged 1 commit into from Feb 16, 2024

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Feb 16, 2024

Refactors trait bound assertions.

@seanmonstar
Copy link
Member

Is there a benefit to this move?

@tottoto
Copy link
Contributor Author

tottoto commented Feb 16, 2024

Since what _assert_types doing is only for tests, I would suppose moving it to test would be easier to read for developers.

seanmonstar
seanmonstar approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay!

@seanmonstar seanmonstar merged commit fb90063 into hyperium:master Feb 16, 2024
10 checks passed
@tottoto tottoto deleted the refactor-trait-bound-assertion branch February 16, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tottoto @seanmonstar