double quote "Sensitive" header value #584
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the implementation of
Debug
forHeaderValue
if a value is not marked sensitive, the value is written to the formatter with double quotes added. However, if marked sensitive the unquoted static stringSensitive
is instead written to the formatter. This causes issues when attempting to output headers during tracing/logging.This PR adds double quotes to the "Sensitive" string output in the case of a sensitive
HeaderValue
.