New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no_std support #563
base: master
Are you sure you want to change the base?
no_std support #563
Conversation
Extensions are also made an optional feature to not require depending on HashMap
|
This looks really good. Wonder if the crate authors will get time to consider it? |
Hm. I guess it doesn't get rid of allocations cause it relies on the |
I'm not sure about getting this into 1.0, but I do want to allow for it. I think the only breaking change would be to add a |
Yes. I got a feeling i've seen more |
I created #637 which does that, allowing us to eventually add support later. |
This PR turns the crate into
no_std
compatible replacingstd
references withcore
+alloc
and adding thestd
feature where needed(std::error::Error
support).Also tried to make the dependency on HashMap optional making extensions an optional feature, the
ahash
dependency shouldn't be an issue since it's already a dependency of hashbrown which is the the std HashMap implementation.