Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of long host with no scheme #351

Merged
merged 4 commits into from Nov 26, 2019
Merged

Fix parsing of long host with no scheme #351

merged 4 commits into from Nov 26, 2019

Commits on Nov 12, 2019

  1. Add failing test for long host with no scheme

    @avitex
    avitex committed Nov 12, 2019
    Copy the full SHA
    caea7af View commit details
    Browse the repository at this point in the history

  2. Fix failing test for long host with no scheme 

    This change fixes an issue where an URI with no scheme, a host
part with a length greater than the max for a scheme, while only
consisting of valid characters for a scheme would fail to parse.

Rather than assuming the string being parsed is meant to contain
a scheme and returning an error if the max length for a scheme is
met, we instead extract the scheme part if it exists and validate
its length.

The tradeoff is worse performance in the error case of a scheme
that is too long.
    @avitex
    avitex committed Nov 12, 2019
    Copy the full SHA
    cc9b27a View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2019

  1. Add failing test for long uri with port and no scheme

    @avitex
    avitex committed Nov 13, 2019
    Copy the full SHA
    d627f3c View commit details
    Browse the repository at this point in the history

  2. Fix failing test for long uri with port and no scheme

    @avitex
    avitex committed Nov 13, 2019
    Copy the full SHA
    d3394b0 View commit details
    Browse the repository at this point in the history