Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http::Error::inner_ref and cause #303

Merged
merged 4 commits into from Apr 2, 2019
Merged

Add http::Error::inner_ref and cause #303

merged 4 commits into from Apr 2, 2019

Commits on Mar 12, 2019

  1. add Error::inner_ref() for access to inner error type 

    Also use `Error::inner_ref` to implement `std::error::Error::cause`
for now. When MSRV is raised to 1.30.0+, this could also be used for
`Error::source` without a breaking change.
    @dekellum
    dekellum committed Mar 12, 2019
    Copy the full SHA
    6565f7e View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. add Error::is helper

    @dekellum
    dekellum committed Apr 1, 2019
    Copy the full SHA
    2d88403 View commit details
    Browse the repository at this point in the history

  2. rename Error::inner_ref to get_ref

    @dekellum
    dekellum committed Apr 1, 2019
    Copy the full SHA
    d6b6885 View commit details
    Browse the repository at this point in the history

  3. make Error::cause be the inner error's cause 

    None of the inner errors currently have a cause, but this is
considered (see PR discussion) the most correct implementation of
`std::error::Error::cause` and is thus future proofed.
    @dekellum
    dekellum committed Apr 1, 2019
    Copy the full SHA
    e19b920 View commit details
    Browse the repository at this point in the history