Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method_ref, uri_ref, headers_ref to request::Builder #284

Merged
merged 3 commits into from Dec 19, 2018
Merged

Add method_ref, uri_ref, headers_ref to request::Builder #284

merged 3 commits into from Dec 19, 2018
+80 −0

Commits on Dec 13, 2018

  1. implement get_method, get_uri, get_headers

    @kazuk
    kazuk committed Dec 13, 2018
    Copy the full SHA
    dfd27c8 View commit details
    Browse the repository at this point in the history

  2. fix compile errors on rust 1.20

    @kazuk
    kazuk committed Dec 13, 2018
    Copy the full SHA
    5d9b7d8 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2018

  1. apply review comments 

    change function name
 get_method -> method_ref
 get_uri -> uri_ref
 get_headers -> header_ref

avoid clone, and returns reference
    @kazuk
    kazuk committed Dec 14, 2018
    Copy the full SHA
    71726ca View commit details
    Browse the repository at this point in the history