Support more tokens for header names #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Nov 1, 2018
Eijebong
force-pushed
the
header-tokens
branch
from
d1a1e5d
to
cdb4c4a
Compare
seanmonstar
reviewed
Nov 1, 2018
Cargo.toml
Outdated
| @@ -4,7 +4,7 @@ name = "http" | |||
| # - Update html_root_url in lib.rs. | |||
| # - Update CHANGELOG.md. | |||
| # - Create git tag | |||
| version = "0.1.13" | |||
| version = "0.1.14" | |||
There was a problem hiding this comment.
Suggested change
| version = "0.1.14" | |
| version = "0.1.13" |
Mind leaving the version change out? We can bump it as part of the changelog generation commit.
According to the RFC both `^` and ` are valid in a header name. This is also making some wpt test fail in servo since they're trying to build a headername with all those characters
Eijebong
force-pushed
the
header-tokens
branch
from
cdb4c4a
to
9e4ef71
Compare
seanmonstar
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the RFC both
^and ` are valid in a header name.This is also making some wpt test fail in servo since they're trying to
build a headername with all those characters