Fix empty Method considered as valid (#262)

hyperium · Oct 18, 2018 · 4a71708 · 4a71708
1 parent f8b3693
commit 4a71708
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/method.rs b/src/method.rs
@@ -143,6 +143,9 @@ impl Method {
     /// Converts a slice of bytes to an HTTP method.
     pub fn from_bytes(src: &[u8]) -> Result<Method, InvalidMethod> {
         match src.len() {
+            0 => {
+                Err(InvalidMethod::new())
+            }
             3 => {
                 match src {
                     b"GET" => Ok(Method(Get)),
@@ -411,3 +414,9 @@ fn test_method_eq() {
     assert_eq!(&Method::GET, Method::GET);
     assert_eq!(Method::GET, &Method::GET);
 }
+
+#[test]
+fn test_invalid_method() {
+    assert!(Method::from_str("").is_err());
+    assert!(Method::from_bytes(b"").is_err());
+}