Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move adapters to http-body-util #56

Merged
merged 2 commits into from May 23, 2022
Merged

Move adapters to http-body-util #56

merged 2 commits into from May 23, 2022

Conversation

g2p
Copy link
Contributor

@g2p g2p commented Feb 23, 2022 •
edited

Move utilities and combinators to a separate package

Hyper works with all combinators removed, as would anything that depends on the initial 0.4 release.

Removing methods from the trait is a breaking change, but it is possible to do the semver trick (release 0.5, then release 0.4.x with a dependency on the 0.5 trait) to not split the ecosystem and make the change painless.

Addresses #52.

@LucioFranco LucioFranco changed the title Move adapters Move adapters to http-body-util Apr 29, 2022
@LucioFranco
Copy link
Member

I think we should merge this @g2p probably worth a force push/fresh commit to trigger CI then we can review/merge?

@g2p
Copy link
Contributor Author

g2p commented Apr 30, 2022

Sure, reworded something and force pushed. I think the CI runs require maintainer approval.

LucioFranco
LucioFranco requested changes May 1, 2022
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly good. That said, can we also move http-body into its own folder?

@g2p
Copy link
Contributor Author

g2p commented May 11, 2022

Both crates have their own folders now.

@g2p g2p requested a review from LucioFranco May 12, 2022 09:21
@seanmonstar
Copy link
Member

This looks good. It aligns with what is written in the hyper roadmap. My question now is, since this is a "breaking change" to http-body, and thus affects hyper, should this stay in a separate branch off master for a while, or should make a 0.4.x branch for maintenance, and let master start being 1.0.0-dev?

@davidpdrsn
Copy link
Member

imo we should merge this to master and start working towards 1.0 there. We can always make a 0.4.x branch and backport things if necessary.

@LucioFranco
Copy link
Member

Yea, lets create a 0.4.x branch when needed and we can start working on master now.

@LucioFranco LucioFranco mentioned this pull request May 20, 2022
Merged
@LucioFranco
Copy link
Member

@g2p can you resolve the conflicts and then we can merge this! thanks.

g2p added 2 commits May 21, 2022 15:36
@g2p
Move utilities and combinators to a separate package
01d2211 
Hyper works with all combinators removed, as would anything that depends
on the initial 0.4 release.

Removing methods from the trait is a breaking change, but it is possible
to do the semver trick (release 0.5, then release 0.4.x with a
dependency on the 0.5 trait) to not split the ecosystem.

Addresses hyperium#52.
@g2p
Clippy fixes
b9bbcc9
@g2p
Copy link
Contributor Author

g2p commented May 21, 2022

@LucioFranco done!

@LucioFranco
Copy link
Member

Thanks!!!

@LucioFranco LucioFranco merged commit aa90d1d into hyperium:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

@LucioFranco LucioFranco LucioFranco approved these changes

@seanmonstar seanmonstar Awaiting requested review from seanmonstar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@g2p @LucioFranco @seanmonstar @davidpdrsn