Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an experimental self update feature #55

Merged
merged 84 commits into from Apr 16, 2024
Merged

Conversation

caendesilva
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5667a4e) 98.03% compared to head (b135972) 98.03%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #55   +/-   ##
=========================================
  Coverage     98.03%   98.03%           
  Complexity       29       29           
=========================================
  Files             6        6           
  Lines           102      102           
=========================================
  Hits            100      100           
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva added the halt-matrix-tests Internal label to halt full suite matrix testing label Dec 13, 2023
@caendesilva caendesilva marked this pull request as draft December 13, 2023 11:31
@caendesilva
Copy link
Member Author

This depends on laravel-zero/framework#481 which seems to be quite stale. Gonna try to create a custom implementation.

@caendesilva caendesilva changed the title Add self update feature Add an experimental self update feature Apr 16, 2024
@caendesilva caendesilva marked this pull request as ready for review April 16, 2024 19:28
@caendesilva
Copy link
Member Author

In the future we'll want to add RSA code signing (where we can embed the public key into the Phar) to guard against MITM attacks, but I think this is fair for an initial experimental proof of concept.

@caendesilva caendesilva merged commit 7e5a3c2 into master Apr 16, 2024
24 checks passed
@caendesilva caendesilva deleted the add-self-update-feature branch April 16, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant