Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support database secrets static roles #662

Merged
merged 1 commit into from Feb 1, 2021
Merged

Support database secrets static roles #662

merged 1 commit into from Feb 1, 2021

Conversation

krish7919
Copy link

@krish7919 krish7919 commented Jan 25, 2021

This PR adds support for database secrets static roles as specified in the Vault documentation at https://www.vaultproject.io/api-docs/secret/databases.

Resolves #661

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #662 (ae1dc4d) into develop (4b4532d) will increase coverage by 0.29%.
The diff coverage is 30.76%.

@@             Coverage Diff             @@
##           develop     #662      +/-   ##
===========================================
+ Coverage    83.49%   83.79%   +0.29%     
===========================================
  Files           59       61       +2     
  Lines         3103     3216     +113     
===========================================
+ Hits          2591     2695     +104     
- Misses         512      521       +9     
Impacted Files Coverage Δ
hvac/api/secrets_engines/database.py 35.71% <30.76%> (-1.50%) ⬇️
hvac/api/auth_methods/jwt.py 92.30% <0.00%> (ø)
hvac/api/secrets_engines/pki.py 100.00% <0.00%> (ø)
hvac/api/auth_methods/approle.py 100.00% <0.00%> (ø)
hvac/constants/approle.py 100.00% <0.00%> (ø)
hvac/v1/__init__.py 86.58% <0.00%> (+0.27%) ⬆️
hvac/api/auth_methods/__init__.py 80.76% <0.00%> (+0.76%) ⬆️

Copy link
Member

@jeffwecan jeffwecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krish7919!

I'll both merge this in, and see cutting a new release, this weekend. edit: Partially to give me some time to see about adding tests for these new methods. So if you care to give that a go in the meantime, feel free :D

@krish7919
Copy link
Author

Merge please? :)

@jeffwecan jeffwecan merged commit 669cb9e into hvac:develop Feb 1, 2021
@jeffwecan jeffwecan added database database secrets engine enhancement a new feature or addition labels Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database database secrets engine enhancement a new feature or addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not support database/static-roles
2 participants