Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced deprecated gulp-util #34

Merged
merged 2 commits into from Jun 11, 2018
Merged

Conversation

zbennett10
Copy link
Contributor

This pr replaces the recently deprecated gulp-util package with corresponding dependencies.

For more info see:

https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
gulpjs/gulp-util#143

Thanks!

@demurgos
Copy link

Hi,
I am not sure if the lock file should be included.

Traditionally, I included it in all of my projects (both applications and libraries) to get reproducible builds. After reading more about it and other lock files (Cargo lock files for Rust) I came to the conclusion that they are very valuable for applications but should be avoided for libraries. The main reason is that they hide issues with dependencies to library authors and CI instead of retrieving the latest versions, this means that consumers are always the first affected by updates in transitive dependencies.

@zbennett10
Copy link
Contributor Author

zbennett10 commented Dec 29, 2017

That makes perfect sense. I made the change. Do you think this should be indicated in the .gitignore?

@demurgos
Copy link

demurgos commented Dec 29, 2017

I updated the PRs I made recently to remove the lock files and add them to the gitignore files. I just hope that adding them to the gitignore files won't delay the PRs even more so it may be safe to not add it.

Edit: I stopped messing with lock files: the best is to keep the situation as is for PRs we send,

@demurgos demurgos mentioned this pull request Jan 3, 2018
@hustxiaoc hustxiaoc merged commit fb84eb3 into hustxiaoc:master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants