Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: support copying token #97

Merged
merged 9 commits into from
May 3, 2024
Merged

docs: support copying token #97

merged 9 commits into from
May 3, 2024

Conversation

TinsFox
Copy link
Contributor

@TinsFox TinsFox commented Apr 29, 2024

For ease of use, I have supported the copying of the current color token in the document.

image

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sugar-high ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 8:31am

Copy link
Owner

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, nice feature!

Notice there're also some extra spaces on the top of color plate, could you fix them aligning with current version? Thanks

docs/app/layout.js Outdated Show resolved Hide resolved
docs/app/live-editor.js Outdated Show resolved Hide resolved
package.json Outdated
@@ -26,4 +27,4 @@
"vitest": "^1.2.2"
},
"packageManager": "pnpm@8.7.1"
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's revert the unrelated changes and keep the file as it was

@@ -126,6 +127,13 @@ export default function LiveEditor() {
}))
const debouncedTokenize = debouncedTokenizeRef.current

const customizableColorsString=useMemo(()=>{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to prettier the changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share your Prettier configuration? My configuration should be different from yours.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or it’s good to just leave the space between the operators like others. I didn’t prettify it but prefer the consistent code style

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that just now, do you see if there are any other issues?

docs/app/components/copy-button.css Outdated Show resolved Hide resolved
@TinsFox
Copy link
Contributor Author

TinsFox commented Apr 29, 2024

Oh, thank you for offering so many suggestions, I will revise it!

@TinsFox
Copy link
Contributor Author

TinsFox commented Apr 29, 2024

Notice there're also some extra spaces on the top of color plate, could you fix them aligning with current version?

Are you referring to this gap?

image

@huozhi
Copy link
Owner

huozhi commented Apr 30, 2024

If you compare with production, the code and "color plate" are having the same padding/marging to the top

image

@TinsFox
Copy link
Contributor Author

TinsFox commented Apr 30, 2024

If you compare with production, the code and "color plate" are having the same padding/marging to the top

I get what you mean.

@TinsFox
Copy link
Contributor Author

TinsFox commented May 3, 2024

@huozhi I just fixed the color plate issue. If you have time, you can check it out again ❤️

Copy link
Owner

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the formatting issues, thanks for the PR!

@huozhi huozhi merged commit 14df889 into huozhi:main May 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants